use jquery.actual to compute height of target element #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure I like the idea of adding a plugin dependency. Is there any logic from jquery.actual that can be inlined in trunk8.js? |
|
I'm sure it could be replicated - there was not a huge amount of code. |
|
Check my pull request (#68) for this. I've added some logic from jQuery.actual to make trunk8 work on hidden elements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a dependency on jquery.actual plugin, and use it to compute height of target, even if not displayed.
The height of a hidden element is 0, but with the plugin the actual height can be detected.