Skip to content

Commit

Permalink
CI/CD: Bump upload-artifact to v4
Browse files Browse the repository at this point in the history
We recently updated the download-artifact action to v4, because earlier
versions were deprecated and stopped working.

Now we ran into the situation, that the release pipeline broke, because
no toolchains are found by the download-artifact action
("Found 0 artifact(s)" although all toolchain builds succeeded and the
resulting toolchain was successfully archived and uploaded).

Looking into the documention of download-artifact@v4 shows the issue:
One of the breaking changes of download-artifact@v4 is "Downloading
artifacts that were created from action/upload-artifact@v3 and below
are not supported." ([1]). Our pipeline uses upload-artifact@v3, which
is why they are not found later on.

Let's bump the upload-artifact action to v4 so that download-artifact@v4
will find the built artifacts again.

[1] https://github.com/actions/download-artifact?tab=readme-ov-file#v4---whats-new

Signed-off-by: Christoph Müllner <[email protected]>
Signed-off-by: Han Gao <[email protected]>
  • Loading branch information
cmuellner authored and RevySR committed Jan 16, 2025
1 parent 626985a commit 6a0d64a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ jobs:
esac
echo "TOOLCHAIN_NAME=riscv$BITS-$MODE-${{ matrix.os }}-${{ matrix.compiler }}-nightly" >> $GITHUB_OUTPUT
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: ${{ steps.toolchain-name-generator.outputs.TOOLCHAIN_NAME }}
path: riscv.tar.gz
6 changes: 3 additions & 3 deletions .github/workflows/nightly-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ jobs:
esac
echo "TOOLCHAIN_NAME=riscv$BITS-$MODE-${{ matrix.os }}-${{ matrix.compiler }}-nightly" >> $GITHUB_OUTPUT
- uses: actions/upload-artifact@v3
- uses: actions/upload-artifact@v4
with:
name: ${{ steps.toolchain-name-generator.outputs.TOOLCHAIN_NAME }}
path: riscv.tar.gz
Expand Down Expand Up @@ -133,7 +133,7 @@ jobs:
prerelease: true

- name: Download Built Artifacts
uses: actions/download-artifact@v2
uses: actions/download-artifact@v4
with:
path: ${{ env.ARTIFACTS_DIR }}

Expand Down Expand Up @@ -174,7 +174,7 @@ jobs:
name: upload ${{ matrix.artifact }}
steps:

- uses: actions/download-artifact@v2
- uses: actions/download-artifact@v4
with:
name: ${{ matrix.artifact }}

Expand Down

0 comments on commit 6a0d64a

Please sign in to comment.