Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ghostty to terminal exception list #94

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

jelmansouri
Copy link
Contributor

The new kid on the block is already quite popular and quite feature complete as of 1.0

@jelmansouri jelmansouri marked this pull request as draft January 7, 2025 03:56
Copy link

github-actions bot commented Jan 7, 2025

Summary of JSON file changes this PR will cause:

 json/windows_shortcuts.json | 120 +++++++++++++++++++++++++++++---------------
 1 file changed, 80 insertions(+), 40 deletions(-)

Detailed diffs:

json/windows_shortcuts.json
diff --git a/json/windows_shortcuts.json b/json/windows_shortcuts.json
index 74156b1..55040c8 100644
--- a/json/windows_shortcuts.json
+++ b/json/windows_shortcuts.json
@@ -24,7 +24,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -79,7 +80,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -134,7 +136,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -191,7 +194,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -247,7 +251,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -302,7 +307,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -354,7 +360,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -411,7 +418,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -467,7 +475,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -522,7 +531,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -574,7 +584,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -629,7 +640,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -686,7 +698,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -741,7 +754,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -798,7 +812,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -853,7 +868,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -908,7 +924,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -963,7 +980,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -1020,7 +1038,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -1075,7 +1094,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -1130,7 +1150,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -1185,7 +1206,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -1240,7 +1262,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -1295,7 +1318,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -1350,7 +1374,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -1405,7 +1430,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -1460,7 +1486,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -1515,7 +1542,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -1570,7 +1598,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -1625,7 +1654,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -1680,7 +1710,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -1735,7 +1766,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -1790,7 +1822,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -1845,7 +1878,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -1900,7 +1934,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -1955,7 +1990,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -2010,7 +2046,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -2063,7 +2100,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "file_paths": [
                         "Chrome Remote Desktop\\.app"
@@ -2785,7 +2823,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "type": "frontmost_application_if"
                   }
@@ -2826,7 +2865,8 @@
                         "^co\\.zeit\\.hyper$",
                         "^com\\.googlecode\\.iterm2$",
                         "^com\\.apple\\.Terminal$",
-                        "^com\\.github\\.wez\\.wezterm$"
+                        "^com\\.github\\.wez\\.wezterm$",
+                        "^com\\.mitchellh\\.ghostty$"
                      ],
                      "type": "frontmost_application_if"
                   }

@jelmansouri jelmansouri marked this pull request as ready for review January 7, 2025 11:47
@Mattrobby
Copy link

@jelmansouri It seems like you forgot to run make and commit the changes to the JSON file.

Once your testing is done, you can simply run make to ensure your changes are syntactically valid jsonnet and that they are formatted. If you don't get any errors, then you should be ready to commit your changes and submit a PR.

@rux616
Copy link
Owner

rux616 commented Jan 16, 2025

@jelmansouri It seems like you forgot to run make and commit the changes to the JSON file.

Once your testing is done, you can simply run make to ensure your changes are syntactically valid jsonnet and that they are formatted. If you don't get any errors, then you should be ready to commit your changes and submit a PR.

The acceptance tests would fail if changes to the JSON file directly were submitted. I have a CI job set up that actually generates, commits, and pushes the changed JSON file once any changes to the main branch are merged.

@rux616
Copy link
Owner

rux616 commented Jan 16, 2025

Thanks for the contribution, @jelmansouri!

@rux616 rux616 merged commit 49e1502 into rux616:main Jan 16, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants