Add key form usability fixes #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eide
commented
Jan 28, 2014
eide
commented
- Display error message if submit fails
- Clear textarea on successfull submit
- Display error message if submit fails - Clear textarea on successfull submit
|
|
||
| // Format of key: algorithm (e.g. ssh-rsa), base64 encoded pubkey and an optional comment | ||
| var keyObj = input.match(/^(.+)\s((?:[A-Za-z0-9+/]{4})*(?:[A-Za-z0-9+/]{2}==|[A-Za-z0-9+/]{3}=)?)(?:\s(.+))?$/); | ||
| if (!keyObj) { | ||
| console.error('Wrong format in submitted key. Example: "ssh-rsa AAAA...== user@host"'); |
There was a problem hiding this comment.
I've been using console.error a few other places as well (mainly fetch errors), with creating a generic error-showing-thing in mind.
Could this be generalized?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.