Support for PartialEq and Eq for objects with an id #18
Conversation
| @@ -86,3 +86,33 @@ macro_rules! impl_room_object_properties { | |||
| )* | |||
| ); | |||
| } | |||
|
|
|||
|
|
|||
| // Macro for mass implementing `StructureProperties`, `PartialEq` and `Eq` for a type. | |||
There was a problem hiding this comment.
I think this could be a doc comment with //!///, but it's not a big deal.
Edit: I'd completely forgotten the difference between //! and /// while reviewing these prs.
The main reason I like doc comments for this sort of thing is that it syntactically attaches the comment to the macro. Even if it's just internal comments for an internal macro, it makes it even clearer that this comment is for the thing under it.
There was a problem hiding this comment.
I changed the // for ///, but I'll wait until #19 is merged before moving this one with the other.
| // | ||
| // # Example | ||
| // ``` | ||
| // macro_rules!(OwnedStructure, Structure, StructureContainer) |
There was a problem hiding this comment.
Unless I'm missing something, I think this line was meant to be something else?
There was a problem hiding this comment.
The copy/paste monster is real!
|
Glad to have you improving this repo! Hope my PR reviews aren't too scrutinous. |
|
Absolutely not, it's all very constructive. Still learning the ropes of rust (which I really like), so your comments help me getting a feel for what is usually left unsaid and best practices. Thanks for taking the time to review my small avalanche of PRs! |
|
Glad to hear it's constructive! Reviewing a small avalanche of PRs is only a tiny bit of work compared to the benefit of extra eyes on the project and the contributions themselves. Thanks for coming and improve |
|
I'll merge this manually since the changes in |
|
Thanks! I was going through the changes. I'll leave it to you. |
|
Ah yeah- that could work! |
This PR adds methods to fetch
ids on the object where this was missing.Given those, it also implements
PartialEqandEqfor all objects with an id.Finally, it also adds
PartialEqandEqforRoombased on name.All of this for partitioning creeps by rooms...