Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(test): Add a new test to ensure proper signature checking #100

Merged
merged 3 commits into from
Jul 26, 2023
Merged

feat(test): Add a new test to ensure proper signature checking #100

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6251819
feat(test): Add a new test to ensure proper signature checking
vincenzopalazzo Jul 14, 2023
ecc260a
fixup! feat(test): Add a new test to ensure proper signature checking
vincenzopalazzo Jul 15, 2023
e4cc9ad
fixup! feat(test): Add a new test to ensure proper signature checking
vincenzopalazzo Jul 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 54 additions & 1 deletion tests/test_bolt2-01-open_channel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
FundChannel,
ExpectMsg,
ExpectTx,
ExpectError,
Msg,
RawMsg,
AcceptFunding,
Expand Down Expand Up @@ -45,7 +46,10 @@
pubkey_of,
gen_random_keyset,
)
from lnprototest.utils.ln_spec_utils import connect_to_node_helper
from lnprototest.utils.ln_spec_utils import (
connect_to_node_helper,
open_and_announce_channel_helper,
)


def test_open_channel_announce_features(runner: Runner) -> None:
Expand Down Expand Up @@ -278,3 +282,52 @@ def test_open_channel_opener_side(runner: Runner) -> None:
TryAll([], RawMsg(bytes.fromhex("270F"))),
]
run_runner(runner, merge_events_sequences(connections_events, test_events))


def test_open_channel_opener_side_wrong_announcement_signatures(runner: Runner) -> None:
"""Testing the case where the channel is announces in the correct way but one node
send the wrong signature inside the `announcement_signatures` message."""
connections_events = connect_to_node_helper(
runner=runner,
tx_spendable=tx_spendable,
conn_privkey="02",
)
opts = {}
open_channel_events = open_and_announce_channel_helper(runner, "02", opts=opts)
pre_events = merge_events_sequences(connections_events, open_channel_events)

dummy_sign = "138c93afb2013c39f959e70a163c3d6d8128cf72f8ae143f87b9d1fd6bb0ad30321116b9c58d69fca9fb33c214f681b664e53d5640abc2fdb972dc62a5571053"
short_channel_id = opts["short_channel_id"]
test_events = [
ExpectMsg(
"announcement_signatures",
channel_id=channel_id(),
short_channel_id=short_channel_id,
node_signature=stash_field_from_event(
"announcement_signatures", dummy_val=dummy_sign
),
bitcoin_signature=stash_field_from_event(
"announcement_signatures", dummy_val=dummy_sign
),
),
# BOLT 7:
# - if the node_signature OR the bitcoin_signature is NOT correct:
# - MAY send a warning and close the connection, or send an error and fail the channel.
#
# In our case, we send an error and stop the open channel procedure. This approach is
# considered overly strict since the peer can recover from it. However, this step is
# optional. If the peer sends it, we assume that the signature must be correct.
Msg(
"announcement_signatures",
channel_id=channel_id(),
short_channel_id=short_channel_id,
node_signature=stash_field_from_event(
"announcement_signatures", dummy_val=dummy_sign
),
bitcoin_signature=stash_field_from_event(
"announcement_signatures", dummy_val=dummy_sign
),
),
ExpectMsg("warning"),
]
run_runner(runner, merge_events_sequences(pre_events, test_events))
Loading