-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the CI runtime, take two #4058
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Systemcluster
force-pushed
the
ci-improve-2
branch
from
August 8, 2024 12:37
ece81e5
to
de1a39d
Compare
Systemcluster
commented
Aug 8, 2024
Systemcluster
commented
Aug 8, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Systemcluster
commented
Aug 8, 2024
Systemcluster
force-pushed
the
ci-improve-2
branch
5 times, most recently
from
August 8, 2024 13:38
a7bf1d0
to
7c81c9b
Compare
Systemcluster
force-pushed
the
ci-improve-2
branch
from
August 8, 2024 13:45
7c81c9b
to
6336631
Compare
Systemcluster
force-pushed
the
ci-improve-2
branch
from
August 8, 2024 14:00
6336631
to
8569e29
Compare
Systemcluster
force-pushed
the
ci-improve-2
branch
from
August 8, 2024 14:04
8569e29
to
2aa2886
Compare
daxpedda
requested changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, thank you for doing this, its a much needed improvement.
Systemcluster
force-pushed
the
ci-improve-2
branch
3 times, most recently
from
August 11, 2024 01:01
2922a54
to
f7faa81
Compare
Systemcluster
force-pushed
the
ci-improve-2
branch
from
August 11, 2024 01:08
f7faa81
to
f6c2911
Compare
Systemcluster
force-pushed
the
ci-improve-2
branch
from
August 11, 2024 01:30
358475d
to
7b1049b
Compare
daxpedda
requested changes
Aug 11, 2024
Co-authored-by: daxpedda <[email protected]>
daxpedda
approved these changes
Aug 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #4047, see there for some earlier review.
It looks like the CI takes about 5 minutes with this PR, one minute down.