Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the CI runtime, take two #4058

Merged
merged 18 commits into from
Aug 11, 2024
Merged

Conversation

Systemcluster
Copy link
Contributor

@Systemcluster Systemcluster commented Aug 8, 2024

Split from #4047, see there for some earlier review.

It looks like the CI takes about 5 minutes with this PR, one minute down.

@Systemcluster Systemcluster marked this pull request as ready for review August 8, 2024 12:35
@Systemcluster

This comment was marked as outdated.

pnpm-workspace.yaml Outdated Show resolved Hide resolved
@Systemcluster Systemcluster force-pushed the ci-improve-2 branch 5 times, most recently from a7bf1d0 to 7c81c9b Compare August 8, 2024 13:38
@Systemcluster Systemcluster marked this pull request as draft August 8, 2024 13:38
@Systemcluster Systemcluster marked this pull request as ready for review August 8, 2024 13:49
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, thank you for doing this, its a much needed improvement.

.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/main.yml Show resolved Hide resolved
@Systemcluster Systemcluster force-pushed the ci-improve-2 branch 3 times, most recently from 2922a54 to f7faa81 Compare August 11, 2024 01:01
.github/workflows/main.yml Outdated Show resolved Hide resolved
Co-authored-by: daxpedda <[email protected]>
Copy link
Collaborator

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daxpedda daxpedda merged commit 031fe89 into rustwasm:main Aug 11, 2024
40 checks passed
@Systemcluster Systemcluster deleted the ci-improve-2 branch August 11, 2024 14:29
@Systemcluster
Copy link
Contributor Author

Thanks for the review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants