Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stabilized wasm feature attributes #122

Merged
merged 1 commit into from
Aug 14, 2018

Conversation

userzimmermann
Copy link
Contributor

@userzimmermann userzimmermann commented Aug 14, 2018

According to rustwasm/book#52 wasm_custom_section and wasm_import_module are stabilized, and not supported anymore by latest nightly rustc

Keeping them results in...

> cargo build
...
error[E0635]: unknown feature `wasm_import_module`
...
error[E0635]: unknown feature `wasm_custom_section`
...

... and makes currently all TravisCI JOB="wasm" builds fail, like https://travis-ci.org/rustwasm/twiggy/jobs/415881546

According to rustwasm/book#52
wasm_custom_section and wasm_import_module are stabilized, and not
supported anymore by latest nightly rustc
@userzimmermann
Copy link
Contributor Author

@fitzgen: I just saw that you actually merged that mentioned rustwasm/book#52 ... So you will surely also merge this one ;)

Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed! Death to feature flags!

@fitzgen fitzgen merged commit e3f04f8 into rustwasm:master Aug 14, 2018
@userzimmermann
Copy link
Contributor Author

🎉 Unblocks #120 :D

@fitzgen

Indeed! Death to feature flags!

Until the next ones are introduced ;P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants