Skip to content

add hyper uninitialized memory advisory #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2022
Merged

Conversation

RalfJung
Copy link
Contributor

@RalfJung RalfJung commented May 10, 2022

Adds an advisory for the fix in hyperium/hyper#2545.

@Shnatsel
Copy link
Member

Uninit memory turned into references may lead to dangling pointers in practice. I'd bump it from informational = unsound to an advisory.

Also I'd like to get sign-off from @seanmonstar so that they don't get a security advisory out of the blue

@RalfJung
Copy link
Contributor Author

I am pretty sure the crate never dereferences that uninit pointer. It was unused. But it had a type which indicated it should be non-null. (In theory the compiler might have introduced spurious loads from that pointer, but we have no evidence of that actually happening.)

@Shnatsel
Copy link
Member

Alright. Since it's an old issue and is only informational = unsound, i.e. a warning, I'll go ahead and merge it without maintainer sign-off.

@Shnatsel
Copy link
Member

Thanks a lot for reporting!

@Shnatsel Shnatsel merged commit 6b7b129 into rustsec:main May 10, 2022
@seanmonstar
Copy link
Contributor

I wouldn't call it a vulnerability myself. The compiler could have done a thing, but it never did. I don't see any reason to warn people, warnings can fatigue.

@RalfJung
Copy link
Contributor Author

RalfJung commented May 10, 2022

The compiler could have done a thing, but it never did.

That's exactly what the "unsound" category is for, I think. It's informational, not a vulnerability.
Quite a few crates came up still depending on old hyper in the crater run rust-lang/rust#87041 so I feel nudging the ecosystem a bit more might be a good idea...

@RalfJung RalfJung deleted the hyper branch May 20, 2022 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants