tests: fixup static lib assertion #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the `verify-static-libraries.py` assertion fails the output with the actual vs expected results was all on one line, making it harder to visually diff. This commit splits the output up across a few lines to make it easier to spot the difference.
It looks like the early duplicate `legacy_stdio_definitions.lib` has fallen away. This commit removes it.
5 tasks
jsha
approved these changes
Mar 23, 2023
jsha
pushed a commit
that referenced
this pull request
Mar 29, 2023
* tests: clarify verify-static-lib output When the `verify-static-libraries.py` assertion fails the output with the actual vs expected results was all on one line, making it harder to visually diff. This commit splits the output up across a few lines to make it easier to spot the difference. * tests: adjust expected native static libs. It looks like the early duplicate `legacy_stdio_definitions.lib` has fallen away. This commit removes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing the remaining rustls-0.21.0 CI failure identified in a smoketest branch.
With these fixes attached to the smoketest branch in addition to the in-flight PRs we get a 🟢 build 🎉: https://github.com/cpu/rustls-ffi/actions/runs/4503112550
tests: clarify verify-static-lib output - 6137272
When the
verify-static-libraries.pyassertion fails the output with the actual vs expected results was all on one line, making it harder to visually diff.This commit splits the output up across a few lines to make it easier to spot the difference.
tests: adjust expected native static libs. - af16029
It looks like the early duplicate
legacy_stdio_definitions.libhas fallen away. This commit removes it from the expected string, leaving only one instance and fixing the test.