Multiple domain components in issuer #301
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da-kami
force-pushed
the
multiple-domain-components-in-issuer
branch
from
5243530 to
7192b84
Compare
cpu
reviewed
Nov 25, 2024
There was a problem hiding this comment.
Hi there, thanks for the issue/PR.
I haven't sat down to form a strong opinion on the core subject, but the specific spot in 5280 you cite and the linked cert-manager issue don't strike me as strong motivation. I think I should page in more context and revisit.
With respect to the diff: it's fairly invasive for an issue that at first glance feels uncommon/niche. Certainly the semver break would be important to avoid unless critical.
WDYT about getting CI to pass and reworking to be semver compatible as a first step?
da-kami
force-pushed
the
multiple-domain-components-in-issuer
branch
from
7192b84 to
b327923
Compare
da-kami
force-pushed
the
multiple-domain-components-in-issuer
branch
from
b327923 to
062af97
Compare
da-kami
force-pushed
the
multiple-domain-components-in-issuer
branch
2 times, most recently
from
e12523c to
0ecfc1b
Compare
djc
reviewed
Jan 16, 2025
There can be multiple of the same entry, e.g. DC (domain component) entries in an issuer.
da-kami
force-pushed
the
multiple-domain-components-in-issuer
branch
from
2e18fbb to
8e0466f
Compare
da-kami
force-pushed
the
multiple-domain-components-in-issuer
branch
from
8e0466f to
dd62f8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #300
I did not invest a big amount of time into changing the interface; please let me know if this PR is welcome otherwise I'm happy to close it. It would be great if #300 can be overcome at some point.