Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PEM decoding for EchConfigListBytes #54

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Support PEM decoding for EchConfigListBytes #54

merged 3 commits into from
Sep 27, 2024

Conversation

ctz
Copy link
Member

@ctz ctz commented Sep 18, 2024

This adopts the "ECHCONFIG" section delimiter proposed in https://www.ietf.org/archive/id/draft-farrell-tls-pemesni-05.html.

(comes after #53)

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this looks good.

One thought: I had also started to sketch this out in rustls/pemfile a while back. In my WIP branch I had also added a server_ech_configs() fn that returned Result<(PrivatePkcs8KeyDer<'static>, EchConfigListBytes<'static>), io::Error> since I imagine most non-test use-cases will want to load both the private key and the ECH config in one go.

Do you think there's any value in adding something like that to this branch?

@ctz ctz force-pushed the jbp-pem branch 5 times, most recently from 6cd7872 to dddfb8d Compare September 25, 2024 15:52
@ctz ctz force-pushed the jbp-pem branch 2 times, most recently from 8d5f39e to 5786284 Compare September 27, 2024 11:12
Base automatically changed from jbp-pem to main September 27, 2024 12:04
@ctz
Copy link
Member Author

ctz commented Sep 27, 2024

Do you think there's any value in adding something like that to this branch?

I've added a separate commit containing one solution to this; WDYT?

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good 👍

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Show resolved Hide resolved
@djc djc mentioned this pull request Sep 27, 2024
@ctz ctz added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 9a1da55 Sep 27, 2024
28 checks passed
@ctz ctz deleted the jbp-pem-ech branch September 27, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants