ci: disable persist-credentials, remove release-plz #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We already do this in most of the other Rustls crates, and Zizmor 0.7.0 flags[0] its absence in this repo. [0]: https://woodruffw.github.io/zizmor/audits/#artipacked
We've traditionally favoured manual releases in the Rustls org, and there are several Zizmor findings with the existing `release-plz.yaml` config. Rather than fix them, let's remove the workflow for now and get on the trusted publishers train when the upstream Rust RFC stabilizes.
djc
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable persist-credentials in test.yml
Adds
persist-credentials: falseintest.yml's use of the checkouts action. Zizmor 0.7.0 flags its absence in this repo. As mentioned in the description of this finding:We don't need it, so turn it off :-)
Remove release-plz workflow
We've traditionally favoured manual releases in the Rustls org, and there are several Zizmor findings with the existing
release-plz.yamlconfig. Rather than fix them, let's remove the workflow for now and get on the trusted publishers train when the upstream Rust RFC (rust-lang/rfcs#3691) stabilizes.Resolves #51