ci: fix clippy findings, update cargo-check-external-types toolchain #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes clippy finding of the form: ``` error: unexpected `cfg` condition value: `bitvec` --> src/ber/ber.rs:13:7 | 13 | #[cfg(feature = "bitvec")] | ^^^^^^^^^^^^^^^^^^ | = note: expected values for `feature` are: `bigint`, `cookie-factory`, `default`, `num-bigint`, `serialize`, `std`, and `unstable` = help: consider adding `bitvec` as a feature in `Cargo.toml` = note: see <https://doc.rust-lang.org/nightly/rustc/check-cfg/cargo-specifics.html> for more information about checking conditional configuration = note: `-D unexpected-cfgs` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(unexpected_cfgs)]` ```
Fixes a clippy finding of the form:
```
error: doc list item missing indentation
--> src/lib.rs:109:4
|
109 | //! for sequences and sets variants
| ^
|
= help: if this is supposed to be its own paragraph, add a blank line
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation
= note: `-D clippy::doc-lazy-continuation` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::doc_lazy_continuation)]`
```
Resolves warning of the form:
```
warning: lint `broken_intra_doc_links` has been renamed to `rustdoc::broken_intra_doc_links`
--> src/lib.rs:237:9
|
237 | #![deny(broken_intra_doc_links)]
| ^^^^^^^^^^^^^^^^^^^^^^ help: use the new name: `rustdoc::broken_intra_doc_links`
|
= note: `#[warn(renamed_and_removed_lints)]` on by default
```
The upstream project cut a 0.1.12 release that now pins Rust nightly-2024-05-01. This commit updates CI to match.
Nope, that's no good. It seems like the code behind the feature gate requires the Probably the right fix is to add an Or perhaps it should be removed since it was unused dead code until now? |
chifflier
added a commit
that referenced
this pull request
Aug 1, 2024
|
I resolved the problem with the bitvec feature and merged your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 As promised, when cargo-check-external-types makes an update I'm opening PRs to fix the builds :-) This project also had several clippy findings that are fixed along the way.
See commit messages for individual explanations. I think adding a
bitvecfeature is the correct fix for theunexpected_cfgsfinding, but this should be double checked.