refactor(errors): improve displaying of errors #322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: simonsan <[email protected]>
simonsan
added
A-errors
simonsan
commented
Oct 8, 2024
crates/core/src/error.rs
Outdated
| FromParseError(#[from] shell_words::ParseError), | ||
| } | ||
|
|
||
| /// [`CryptoErrorKind`] describes the errors that can happen while dealing with Cryptographic functions | ||
| #[derive(Error, Debug, Display, Copy, Clone)] | ||
| pub enum CryptoErrorKind { | ||
| /// data decryption failed | ||
| /// data decryption failed: `{0:?}` |
There was a problem hiding this comment.
The underlying error was not shown to the user, so this ended in a simple: data decryption failed. Which is not really helpful. The hope is, that aead:Error is a bit more helpful here.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 9, 2024
Based on #322 --------- Signed-off-by: simonsan <[email protected]>
|
Was merged with #323 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #231