Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(commands): Add option stdin_command to be used in CLI and config file #266

Merged
merged 15 commits into from
Sep 21, 2024

Apply suggestions from code review

05d1898
Select commit
Loading
Failed to load commit list.
Merged

feat(commands): Add option stdin_command to be used in CLI and config file #266

Apply suggestions from code review
05d1898
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 21, 2024 in 0s

48.6% (+0.8%) compared to ec3aa46

View this Pull Request on Codecov

48.6% (+0.8%) compared to ec3aa46

Details

Codecov Report

Attention: Patch coverage is 54.54545% with 25 lines in your changes missing coverage. Please review.

Project coverage is 48.6%. Comparing base (ec3aa46) to head (05d1898).

Files with missing lines Patch % Lines
crates/core/src/commands/backup.rs 36.8% 12 Missing ⚠️
crates/core/src/backend.rs 50.0% 4 Missing ⚠️
crates/core/src/repository/command_input.rs 60.0% 4 Missing ⚠️
crates/core/src/backend/childstdout.rs 81.2% 3 Missing ⚠️
crates/core/src/backend/stdin.rs 0.0% 2 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
crates/core/src/error.rs 57.1% <ø> (ø)
crates/core/tests/integration.rs 77.7% <ø> (+0.8%) ⬆️
crates/core/src/backend/stdin.rs 0.0% <0.0%> (ø)
crates/core/src/backend/childstdout.rs 81.2% <81.2%> (ø)
crates/core/src/backend.rs 57.5% <50.0%> (+0.6%) ⬆️
crates/core/src/repository/command_input.rs 65.9% <60.0%> (+3.1%) ⬆️
crates/core/src/commands/backup.rs 62.5% <36.8%> (+3.4%) ⬆️

... and 20 files with indirect coverage changes