-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add tls-native, tls-rustls features to allow building w/o Rustls #110
base: main
Are you sure you want to change the base?
Conversation
Hey there, we are currently working on a relatively big refactor to an own We need to focus first on that one, before we are being able to merge this. |
Also regarding the topic, as there has been no issue, which needs to be fixed, and we haven't discussed it, could you elaborate a bit on the background:
|
Agree to @simonsan - when the backend refactor is done, the TLS things will be all in the crate rustic_backends, so we better wait for the refactoring #73 to land! Besides this, if there are use cases where you need other TLS options, I would very much agree to adding the possibilites as features. It might be that the depending crate(s) (e.g. opendal) need to support those features, too... |
Packaging rustic for Alpine Linux.
Bundling (static linking) TLS library is a very bad idea from a security perspective, and Linux distributions try to avoid it. Also, rustls/ring doesn’t support all platforms supported by Rust, e.g. ppc64le and s390x. |
@jirutka if the features are mutually exclusive, could you throw a compile error in #[cfg(all(feature = "tls-native", feature = "tls-rustls "))]
compile_error!("feature \"tls-native\" and feature \"tls-rustls \" cannot be enabled at the same time. Please disable one of them."); |
Sure, done. |
Patch backported from rustic-rs/rustic_core#110
Now that #73 is merged, this PR can continue... Also, now that we have added opendal, this should be also treated - however, I don't know if this is already supported by opendal; this may need a bit of research. |
No description provided.