Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Encoder and Decoder for Box<T> #644

Merged
merged 1 commit into from
Aug 9, 2024
Merged

Implement Encoder and Decoder for Box<T> #644

merged 1 commit into from
Aug 9, 2024

Conversation

dvic
Copy link
Contributor

@dvic dvic commented Aug 8, 2024 •
edited
Loading

I encountered a Clippy warning that my enum got too big and I should box up my inner value, hence the PR ^^.

@filmor
Copy link
Member

filmor commented Aug 9, 2024

Maybe expand the Encoder for all Deref<Target=T>?

@dvic
Copy link
Contributor Author

dvic commented Aug 9, 2024

Maybe expand the Encoder for all Deref<Target=T>?

You mean like below? I get a conflicting implementation error like this

image

@filmor filmor merged commit a0ddedf into rusterlium:master Aug 9, 2024
46 checks passed
@dvic dvic deleted the box-encoder-decoder branch August 9, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvic @filmor