Fix rustler_sys tests on 64bit ARM #584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scrogson
approved these changes
Jan 5, 2024
Whether c_char is i8 or u8 is platform-dependent (https://doc.rust-lang.org/std/ffi/type.c_char.html), this is the only place where it is relevant so far, though. We could adjust the `rustler` struct and type mappings as well.
filmor
force-pushed
the
fix-rustler-sys-test-on-arm64
branch
from
4f9afbe
to
2e25a45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whether c_char is i8 or u8 is platform-dependent
(https://doc.rust-lang.org/std/ffi/type.c_char.html), this is the only place
where it is relevant so far, though. We could adjust the
rustlerstruct andtype mappings as well.