Remove cfg! directives in build.rs causing cross-compilation to fail #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziosestito
changed the title
|
Thanks a lot, I didn't think of this when I was refactoring the script :) |
filmor
pushed a commit
that referenced
this pull request
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By bumping
rustlerto0.29.0in a project usingrustler_precompiled, I realized that the cross-compilation of some targets fails.For instance, when compiling rustler with
cargo build --target=arm-unknown-linux-gnueabihf, the ulong_size is not picked up correctly.This is because the build.rs is compiled by the host prior to being executed, so the
cfg!macro refers to the host configuration.This PR reverts the usage of the
cfg!macro in favor of theCARGO_*env variables.