Update Rust Edition #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
reviewed
Jan 13, 2024
CHANGELOG.md
Outdated
| @@ -1,4 +1,5 @@ | |||
| # Unreleased | |||
| - Update from 2018 Rust Edtion to 2021 | |||
There was a problem hiding this comment.
Fwiw this only has meaning to code compiled within the crate, not to external crates consuming this, so there's no real reason to mention it in the changelog?
There was a problem hiding this comment.
This crate is pretty small and the changelog usally contains smaller things like Deps. updates, Many crates putting Editions changes in their changelog
msiglreith
reviewed
Jan 15, 2024
Co-authored-by: Markus Siglreithmaier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.