Add an iterator over XFB rows #25
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libstd’s runtime changed the prototype of lang = "start" in ddee45e1d7fd34563c13513d974f792fae41a2f7 to support changing the SIGPIPE behaviour on Linux, so this function now takes a third argument on every platform. Additionally, it now supports user_main() returning any Termination, so we don’t need a transmute() any longer. :)
This fixes the build on current nightly (since 2023-04-22).
This emits slices of u16, and allows users to not use unsafe for drawing.
|
|
||
| /// A struct representing the eXternal FrameBuffer, or XFB. It represents the image that will be | ||
| /// sent to the screen, in YUYV format. It must be allocated as contiguous physical memory. | ||
| pub struct Xfb { | ||
| data: Pin<Box<[u8]>>, | ||
| data: Box<[u16]>, |
There was a problem hiding this comment.
The data needs to be pinned for the duration of the use of the XFB due to mmio usage. Rust doesn't confirm that the pointer wont move.
ProfElements
requested changes
Dec 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This emits slices of
u16, and allows users to not use unsafe for drawing.This is based on #21, since it wouldn’t build on current nightly otherwise.