Minor QoL improvements for kvm_xsave2 #315
Open
+11
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roypat
requested review from
acatangiu,
andreeaflorescu,
lauralt,
sameo and
ShadowCurse
as code owners
ShadowCurse
previously approved these changes
Mar 10, 2025
Construct an kvm_xsave2 with length set to 0. Useful when only a kvm_xsave is at hand, but an API demands a kvm_xsave2, so the kvm_xsave needs to converted into a Xsave with empty flexible array. Signed-off-by: Patrick Roy <[email protected]>
The length of the FAM is not in bytes, but rather in terms of how many __u32 elements are contained in the flexible array member. So clarify the note that the return value of KVM_CHECK_EXTENSION not only needs to subtract sizeof::<kvm_xsave>(), it also needs to divide by 4. Signed-off-by: Patrick Roy <[email protected]>
roypat
force-pushed
the
xsave2-corrections
branch
from
09c85c5 to
ab7c5ad
Compare
ShadowCurse
approved these changes
Mar 10, 2025
zulinx86
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Please summarize here why the changes in this PR are needed.
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.