-
-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-org with distr::slice, distr::weighted modules #1548
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This remains available as rand::seq::WeightError.
This isn't clear enough on GitHub Actions pages
benjamin-lieser
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks fine to me (minus the two comments on the CI) and I think it makes sense to organize it in this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.md
entrySummary
Re-organise / rename a few things in
rand::distr
andrand_distr
:Slice
->slice::Choose
,EmptySlice
->slice::Empty
DistString
->SampleString
DistIter
->Iter
,DistMap
->Map
{Weight, WeightError, WeightedIndex}
->weighted::{Weight, Error, WeightedIndex}
weighted_alias::{AliasableWeight, WeightedAliasIndex}
->weighted::{..}
weighted_tree::WeightedTreeIndex
->weighted::WeightedTreeIndex
Motivation
Some things like
Slice
andDistString
weren't that obvious from the name. Now I find the purpose clearer from the path.For
rand_distr
, all weighted distributions are now under a single module which is better for doc and shared stuff likeWeight
. (Possibly we should go further and move them all to a new crate? But maybe not sincerand::seq::IndexedRandom
also supports weighted sampling.)Possibly more re-organisation of
rand_distr
is justified. The "flat organisation" system works well enough though.