Skip to content

Update 0.1 branch to use Github actions #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 4, 2021
Merged

Update 0.1 branch to use Github actions #190

merged 1 commit into from
Jan 4, 2021

Conversation

josephlr
Copy link
Member

@josephlr josephlr commented Jan 3, 2021

Also update the badges in the README

Signed-off-by: Joe Richey [email protected]

@josephlr josephlr requested a review from newpavlov January 3, 2021 02:15
@josephlr josephlr force-pushed the actions branch 2 times, most recently from 47cfda2 to 70ab6ed Compare January 3, 2021 04:09
newpavlov
newpavlov approved these changes Jan 3, 2021
View reviewed changes
Copy link
Member

@newpavlov newpavlov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it's worth to simply remove the commented out lines in the workflow config?

@josephlr
Copy link
Member Author

josephlr commented Jan 3, 2021

Maybe it's worth to simply remove the commented out lines in the workflow config?

Ya, I'm just going to copy over the config from #192 and see if I can just use that.

@josephlr josephlr force-pushed the actions branch 2 times, most recently from 98f3e09 to 4aace46 Compare January 3, 2021 14:23
@josephlr
Copy link
Member Author

josephlr commented Jan 3, 2021

Ok @newpavlov, this is now just a slightly modified version of the config in #192, and all 34 of the jobs are now passing. So once you approve that one, I'll merge this one.

newpavlov
newpavlov approved these changes Jan 4, 2021
View reviewed changes
Copy link
Member

@newpavlov newpavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some minor comments in #192 which apply here as well, but otherwise looks good!

@josephlr
Update 0.1 branch to use Github actions
42fe51e 
Also update the badges in the README

Signed-off-by: Joe Richey <[email protected]>
@josephlr
Copy link
Member Author

josephlr commented Jan 4, 2021

I left some minor comments in #192 which apply here as well, but otherwise looks good!

Applied the fixed from #192 to this branch

@josephlr josephlr merged commit 9183727 into 0.1 Jan 4, 2021
@josephlr josephlr deleted the actions branch January 4, 2021 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newpavlov newpavlov newpavlov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josephlr @newpavlov