Improve CI for web targets #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run WASI tests, and run both stdweb/wasm-bindgen on both node and in browsers These changes also remove the need for a separate tests/wasm_bindgen
Co-Authored-By: Artyom Pavlov <[email protected]>
josephlr
force-pushed
the
ci
branch
5 times, most recently
from
92e5ff3 to
f6c8766
Compare
|
Updated description to reflect the scope of these changes. @dhardy this is ready, the CI runs significantly faster now. |
|
I would prefer that someone more familiar with WASM could review. @stevebob wrote this test originally (rand#696). |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses simplifies the testing story for
getrandom. All targets now use the same testing file (eliminating the need for a separatetests/wasm_bindgencrate).We also use
.cargo/configto allow users to runcargo testnormally forwasm32-wasiorwasm32-unknown bindgen. This just requires thatwasmtimeorwasm-bindgen-test-runnerexist in the user's path.The CI for these targets has been overhauled:
wasm32-wasistdweb: Node and Chromewasm-bindgen: Node, Firefox, and Chromeasmjs-unknown-emscriptenResults:
This is not part of #98, so it can be merged into master.