-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WithMipGap trait #38
Conversation
@mmghannam any idea how hard it would be to implement mip gap in russcip ? |
I think implementing MIP gap in russcip should be as simple as calling
A |
@mmghannam what do you think? Maybe russcip could allow setting parameters in the ProblemCreated state? Or would that introduce the possibility for an inconsistent state ? @mfuhr : anyway, I don't see an issue with with merging this PR without russcip support now, and adding it later. |
Setting parameters in |
How's the latest? |
…imal and suboptimal solutions
@lovasoa I'd be happy to make any more changes you suggest. Thanks for the help -- I'm pretty new to Rust and to GitHub collaboration so your feedback has been very useful! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great, and the example is very well explained. Thanks, I'll release a new version.
Add a
WithMipGap
trait and implement it forcoin_cbc
,highs
, andlp_solvers
. This trait mimics the trait of the same name that we recently added to the lp-solvers crate.Implementing
WithMipGap
forlpsolve
andscip
appears to be non-trivial so I haven't done those, andminilp
doesn't support integer variables.I created a macro for generating tests of the
WithMipGap
trait. This is my first experience writing a Rust macro so hopefully it's okay. It does work as intended.