Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Default constraint to PrimInt #43

Closed
wants to merge 1 commit into from

Conversation

jturner314
Copy link
Contributor

I don't see any reason to intentionally leave off a Default trait bound, and it's useful to have. Note that this is technically a breaking change for anyone who has implemented PrimInt for their own types, so it should probably be part of num-traits 0.3 instead of 0.2.2.

@cuviper
Copy link
Member

cuviper commented Mar 4, 2018

I have no short-term plans to make breaking changes. Rather than leaving a PR in limbo, can you file a tracking issue for this? #36 also wanted Display and Debug.

@jturner314
Copy link
Contributor Author

Okay. I created issue #44.

@jturner314 jturner314 closed this Mar 4, 2018
@jturner314 jturner314 deleted the primint-default branch March 4, 2018 03:17
@cuviper
Copy link
Member

cuviper commented Mar 4, 2018

Thanks!

@cuviper cuviper modified the milestone: num-traits-0.x Mar 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants