Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow appending neighbor entries, which is useful with certain kernel drivers #61

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mepholic
Copy link

@mepholic mepholic commented Apr 9, 2024

This is my attempt at fixing issue #60

I've left more commentary on the issue, and spent some time reading kernel sources. I think this solution should be sufficient for now, but I don't know if my approach at making REPLACE override APPEND if both are specified is a good idea. I wasn't sure what the project's guidelines were on error handling, and if generating an error from the library itself was acceptable, or if having netlink complain (or possibly silently do something weird) is preferred.

I've tested the code for my particular use case, and it works great!

If anybody has any thoughts on this implementation, I'd be happy to attempt to solve this another way. 😀

… drivers

This is my attempt at fixing issue rust-netlink#60 on the Github project.
@cathay4t
Copy link
Member

cathay4t commented Apr 9, 2024

Please do similar stuff like #57 by using a builder.

The builder approach is collecting all configurations and generate the final netlink message at final call of build(), it is better than current approach on modifying internal stored netlink message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants