Do not fail on unknown option of bond and vlan #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should always use `Other()` to hold unknown bond options. Signed-off-by: Gris Ge <[email protected]>
We should always use `Other` to store unknown option instead of raise error. Signed-off-by: Gris Ge <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #73 +/- ##
==========================================
- Coverage 65.28% 63.38% -1.91%
==========================================
Files 121 131 +10
Lines 8059 8288 +229
==========================================
- Hits 5261 5253 -8
- Misses 2798 3035 +237 ☔ View full report in Codecov by Sentry. |
All `InfoData` not properly parsed is changed from `Vec<u8>` to `Vec<InfoXXX>` with place holder. Signed-off-by: Gris Ge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two patches to fix
LinkInfofor bond and vlan where we should always storeunknown option to
Other(DefaultNla)instead of raising error.All
InfoDatanot properly parsed is changed fromVec<u8>toVec<InfoXXX>with place holder.