[API break] [last refactor] nsid: Reorganize the code base #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cathay4t
changed the title
* This patch is first preparation on stable release 1.0 for submodule nsid. The detailed checklist for developer is stated in README.md file. * Stored constants into where it been used. Removed `constants.rs` as this is the last submodule for refactor. * Replace `pub use self::*` to explicit expose. * Renamed `nsid::Nla` to `NsidAttribute` and all its entry changed to detailed data structure instead of `Vec<u8>` * The `RtnlMessasge` changed to `RouteNetlinkMessage`. * Unit test cases included. Signed-off-by: Gris Ge <[email protected]>
cathay4t
force-pushed
the
v1_prep_nsid
branch
from
4e35a89
to
7822585
Compare
Signed-off-by: Gris Ge <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
==========================================
+ Coverage 62.52% 66.93% +4.41%
==========================================
Files 98 99 +1
Lines 7108 7473 +365
==========================================
+ Hits 4444 5002 +558
+ Misses 2664 2471 -193 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nsid. The detailed checklist for developer is stated in
README.md file.
constants.rsas this is the last submodule for refactor.
pub use self::*to explicit expose.nsid::NlatoNsidAttributeand all its entrychanged to detailed data structure instead of
Vec<u8>RtnlMessasgechanged toRouteNetlinkMessage.