Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix parsing error on empty IFLA_AF_SPEC #138

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix parsing error on empty IFLA_AF_SPEC #138

wants to merge 3 commits into from

Conversation

bebecue
Copy link
Contributor

@bebecue bebecue commented Oct 4, 2024

No description provided.

cathay4t
cathay4t requested changes Jan 20, 2025
View reviewed changes
Copy link
Member

@cathay4t cathay4t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you include a unit test case with captured netlink message for this?

@cathay4t cathay4t added the Wait_Submitter PR reviewed with change requests label Jan 20, 2025
@bebecue
Copy link
Contributor Author

bebecue commented Jan 21, 2025

Yes, I added one in d80436b

@bebecue bebecue requested a review from cathay4t January 21, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cathay4t cathay4t Awaiting requested review from cathay4t

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Wait_Submitter PR reviewed with change requests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bebecue @cathay4t