Add tc-flower(8) support #135
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The cargo fmt check failed, please fix it, thanks. |
AlexanderChernikov
force-pushed
the
main
branch
from
8f3a143
to
8d79942
Compare
Whoops! Non-nightly fmt version doesn't feel comfortable touching the comments. Formatted with nightly. |
AlexanderChernikov
force-pushed
the
main
branch
from
8d79942
to
999f491
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly complete tc-flower implementation (94/96) attributes supported (and covered with tests).
The only missing is TCA_FLOWER_KEY_ENC_OPTS handling. I plan to add support for it it this week.
Tested on 5.15.0-118-generic (so does netlink captures).
I've added a small python tool (stock python3, no dependencies) to simplify netlink dumps for rtnelink, providing those in ready-to-insert-to-the-test format.
I've also added a number of changes to actions code, including adding
tunnel_keyaction - happy to split those to separate requests if needed. I also plan to addctandtc-peditin the next couple of weeks.Happy to work towards addressing all concerns and getting this landed.