Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link: ipvlan: Change mode type from u16 to Enum. #108

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

xujunjie-cover
Copy link
Contributor

link: ipvlan: Change mode type from u16 to Enum.

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 64.00%. Comparing base (a543bb7) to head (16a96be).

Files Patch % Lines
src/link/link_info/ipvlan.rs 63.15% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #108      +/-   ##
==========================================
- Coverage   64.01%   64.00%   -0.02%     
==========================================
  Files         140      140              
  Lines        8518     8535      +17     
==========================================
+ Hits         5453     5463      +10     
- Misses       3065     3072       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cathay4t cathay4t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cathay4t
Copy link
Member

@xujunjie-cover Thanks for the contribution! Please run cargo fmt against your patch to make CI happy. After that, we can merge it.

@xujunjie-cover
Copy link
Contributor Author

@xujunjie-cover Thanks for the contribution! Please run cargo fmt against your patch to make CI happy. After that, we can merge it.

done. Thanks.

@cathay4t cathay4t merged commit 396d4b0 into rust-netlink:main Mar 29, 2024
8 of 10 checks passed
@cathay4t
Copy link
Member

Hi @xujunjie-cover, please wait 1 more week for other PR to merged. When I will tag new release for you to use this in rtnetlink.

@xujunjie-cover
Copy link
Contributor Author

Hi @xujunjie-cover, please wait 1 more week for other PR to merged. When I will tag new release for you to use this in rtnetlink.

OK,I also want to add ipvtap, is that okay?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants