Fix cargo clippy warnings

Signed-off-by: Gris Ge <[email protected]>
rust-netlink · Sep 4, 2024 · e12f9be · e12f9be
1 parent 2fd4c35
commit e12f9be
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 19 deletions.
diff --git a/src/link/tests/bond.rs b/src/link/tests/bond.rs
@@ -1,14 +1,12 @@
 // SPDX-License-Identifier: MIT
 
-use netlink_packet_core::{NetlinkHeader, NetlinkMessage, NetlinkPayload};
 use netlink_packet_utils::{Emitable, Parseable};
 
 use crate::link::link_flag::LinkFlags;
 use crate::link::{
     BondArpValidate, BondMode, BondPortState, InfoBond, InfoBondPort, InfoData,
     InfoKind, InfoPortData, InfoPortKind, LinkAttribute, LinkHeader, LinkInfo,
-    LinkLayerType, LinkMessage, LinkMessageBuffer, LinkXdp, Map, MiiStatus,
-    State, Stats, Stats64,
+    LinkLayerType, LinkMessage, LinkMessageBuffer, Map, MiiStatus, State,
 };
 use crate::{AddressFamily, RouteNetlinkMessage};
 

diff --git a/src/link/tests/geneve.rs b/src/link/tests/geneve.rs
@@ -40,9 +40,7 @@ fn test_geneve_link_info() {
             LinkInfo::Kind(InfoKind::Geneve),
             LinkInfo::Data(InfoData::Geneve(vec![
                 InfoGeneve::Id(42),
-                InfoGeneve::Remote6(
-                    Ipv6Addr::from_str("2001:db8::1").unwrap().into(),
-                ),
+                InfoGeneve::Remote6(Ipv6Addr::from_str("2001:db8::1").unwrap()),
                 InfoGeneve::UdpZeroCsum6Tx(false),
                 InfoGeneve::Ttl(10),
                 InfoGeneve::Tos(18),

diff --git a/src/link/tests/vrf.rs b/src/link/tests/vrf.rs
@@ -352,7 +352,7 @@ fn test_link_info_with_ifla_vrf_port_table() {
     };
     let link = LinkMessage::parse(&LinkMessageBuffer::new(&data)).unwrap();
     assert_eq!(expected, link);
-    let mut buf = vec![0; data.len()];
+    let _buf = vec![0; data.len()];
     // FIXME: the packet we write is not a perfect match with the
     // packet we received from the kernel.
     //

diff --git a/src/link/tests/vxlan.rs b/src/link/tests/vxlan.rs
@@ -229,13 +229,9 @@ fn test_parsing_link_vxlan() {
                 LinkInfo::Kind(InfoKind::Vxlan),
                 LinkInfo::Data(InfoData::Vxlan(vec![
                     InfoVxlan::Id(101),
-                    InfoVxlan::Group(
-                        Ipv4Addr::from_str("8.8.8.8").unwrap().into(),
-                    ),
+                    InfoVxlan::Group(Ipv4Addr::from_str("8.8.8.8").unwrap()),
                     InfoVxlan::Link(13),
-                    InfoVxlan::Local(
-                        Ipv4Addr::from_str("1.1.1.1").unwrap().into(),
-                    ),
+                    InfoVxlan::Local(Ipv4Addr::from_str("1.1.1.1").unwrap()),
                     InfoVxlan::Ttl(0),
                     InfoVxlan::TtlInherit(false),
                     InfoVxlan::Tos(0),
@@ -463,13 +459,9 @@ fn test_parsing_link_vxlan_ipv6() {
                 LinkInfo::Kind(InfoKind::Vxlan),
                 LinkInfo::Data(InfoData::Vxlan(vec![
                     InfoVxlan::Id(12),
-                    InfoVxlan::Group6(
-                        Ipv6Addr::from_str("ff00::1").unwrap().into(),
-                    ),
+                    InfoVxlan::Group6(Ipv6Addr::from_str("ff00::1").unwrap()),
                     InfoVxlan::Link(2),
-                    InfoVxlan::Local6(
-                        Ipv6Addr::from_str("fd01::2").unwrap().into(),
-                    ),
+                    InfoVxlan::Local6(Ipv6Addr::from_str("fd01::2").unwrap()),
                     InfoVxlan::Ttl(0),
                     InfoVxlan::TtlInherit(false),
                     InfoVxlan::Tos(0),