Skip to content

Re-implement intel-mkl-tool #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Aug 4, 2022
Merged

Re-implement intel-mkl-tool #81

merged 29 commits into from
Aug 4, 2022

Conversation

termoshtt
Copy link
Member

@termoshtt termoshtt commented Aug 2, 2022

intel_mkl_tool::Entry is rewritten into intel_mkl_tool::Library.

Changes

  • Seek given directory recursively.
  • Do not use pkg-config crate. Manually call pkg-config --variable=prefix mkl-*-*-*, and seek libraries there.
  • Do not seek all libraries. Seek only mkl.h, libmkl_core.{a,so}, and libiomp5.{a,so}
  • Remove intel-mkl-tool CLI

@termoshtt termoshtt self-assigned this Aug 2, 2022
@termoshtt termoshtt force-pushed the rewrite-tool-entry branch from fdfd37e to 9c0ed5e Compare August 2, 2022 09:02
@termoshtt termoshtt force-pushed the rewrite-tool-entry branch from c1066fb to 5b7dcd0 Compare August 2, 2022 12:16
@termoshtt termoshtt mentioned this pull request Aug 2, 2022
@termoshtt
Copy link
Member Author

termoshtt commented Aug 3, 2022

cargo metadata of pkg-config crate looks wrong for mkl-static-*-* cases rust-lang/pkg-config-rs#135

I switch to use pkg-config only find library, generate cargo metadata manually, i.e. reverts #65

@termoshtt termoshtt force-pushed the rewrite-tool-entry branch from 69ad3a3 to c60613d Compare August 3, 2022 14:41
@termoshtt termoshtt force-pushed the rewrite-tool-entry branch from 006ce71 to 07fbbb4 Compare August 4, 2022 05:20
@termoshtt termoshtt force-pushed the rewrite-tool-entry branch from 72b86b2 to 6d53319 Compare August 4, 2022 06:42
@termoshtt termoshtt changed the title Rewrite intel_mkl_tool::Entry Re-implement intel-mkl-tool Aug 4, 2022
@termoshtt termoshtt marked this pull request as ready for review August 4, 2022 10:47
@termoshtt termoshtt merged commit 83d04c0 into master Aug 4, 2022
@termoshtt termoshtt deleted the rewrite-tool-entry branch August 4, 2022 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant