marker_adapter: Support non-utf8 paths
#108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#103 makes me a bit concerned of any unchecked windows changes now, so let's see what bors has to say first. bors try |
tryBuild failed: |
Niki4tap
force-pushed
the
os-and-strings
branch
from
eaa7605 to
380c23f
Compare
Niki4tap
force-pushed
the
os-and-strings
branch
from
380c23f to
75154d3
Compare
|
Hmmm, seems like github CI clippy doesn't trigger on bors try |
tryBuild succeeded: |
xFrednet
approved these changes
Feb 8, 2023
|
Looks good to me and I like the changes. Thank you! bors r+ |
|
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
marker_adapteruseOsStrings to support paths which might not be utf-8.Fixes #67