Ignore comment edited with no changes #1911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apiraino
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes it so that when GitHub sends an issue comment "edited" event with no changes, triagebot will ignore it.
For unknown reasons, sometimes when someone posts a PR review, GitHub sends an "edited" event with
"changes":{}, immediately followed by a "created" event with the actual content, which doesn't make much sense. I'm pretty sure that any "edited" event without changes can be safely ignored. For example, under normal circumstances GitHub will correctly report empty bodies with the empty string (not null), so those should still continue to be handled correctly.Fixes #1881