Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also show warnings when PRs are updated #1901

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Feb 9, 2025

This PR tweaks the assign handler to also show warnings when PRs are updated, instead of just doing it when a PR is opened.

Fixes #1831
r? @ehuss

@Urgau Urgau force-pushed the warnings-on-synchronize branch from 7e5fac3 to 0e2641e Compare February 9, 2025 10:46
@ehuss
Copy link
Contributor

ehuss commented Feb 9, 2025

This looks like it will warn on every push, is that right? If possible I'd like to avoid that (maybe with IssueData?).

@Urgau
Copy link
Member Author

Urgau commented Feb 10, 2025

That's a good observation, it would indeed post unnecessary comments.

As suggested I have used IssueData with some state to keep track of the last warnings to avoid posting unnecessary comments. I haven't tested it, but it's very similar to the other avoid comment logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modified submodules are only warned about on PR creation
2 participants