Add review_submitted handler which changes labels after a review #1379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When an assigned reviewer submits a review to a PR, automatically remove waiting-on-review and add waiting-on-author label
|
I think an approving review shouldn't mark the PR as waiting on author. |
|
Didn't consider that case, thanks. I've added it now |
mibac138
commented
Jun 6, 2021
src/github.rs
Outdated
Comment on lines
295
to
306
| #[serde(rename = "state")] | ||
| pub pr_review_state: PullRequestReviewState, | ||
| } | ||
|
|
||
| #[serde(rename_all = "SCREAMING_SNAKE_CASE")] | ||
| #[derive(Debug, serde::Deserialize)] | ||
| pub enum PullRequestReviewState { | ||
| Approved, | ||
| ChangesRequested, | ||
| Commented, | ||
| Dismissed, | ||
| Pending, |
There was a problem hiding this comment.
I think this is correct, but I'd appreciate if this was double checked before merging
|
Oooh, nice! |
nikomatsakis
suggested changes
Jun 8, 2021
| return Ok(()); | ||
| } | ||
|
|
||
| if event.issue.assignees.contains(&event.comment.user) { |
There was a problem hiding this comment.
I think we should only do this for "Request Changes". I'm not sure how to interpret a simple "comment" review that has no "inclination".
There was a problem hiding this comment.
Makes sense, changed it
nikomatsakis
approved these changes
Jun 16, 2021
nikomatsakis
approved these changes
Jun 17, 2021
| @@ -292,6 +292,18 @@ pub struct Comment { | |||
| pub user: User, | |||
| #[serde(alias = "submitted_at")] // for pull request reviews | |||
| pub updated_at: chrono::DateTime<Utc>, | |||
| #[serde(rename = "state")] | |||
| pub pr_review_state: PullRequestReviewState, | |||
There was a problem hiding this comment.
I believe this may have broken deserialization of issue comments -- I'm filing a fix now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1373
cc @nikomatsakis