Give types team members access to perf, crater and dev-desktops. #963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oli-obk
force-pushed
the
master
branch
2 times, most recently
from
5512ad0 to
d1dded6
Compare
|
+1 from me |
rylev
reviewed
Mar 28, 2023
| @@ -39,3 +39,7 @@ extra-people = ["eholk"] | |||
|
|
|||
| [permissions] | |||
| bors.chalk.review = true | |||
| bors.rust.try = true | |||
| perf = true | |||
| crater = true | |||
There was a problem hiding this comment.
Crater runs don't happen super often. Given that they take a large amount of expensive machinery to run it seems reasonable to limit its use. Is there any reason the types team members can't reach out to a compiler team member when this is needed?
There was a problem hiding this comment.
Crater runs don't happen super often
Types team members run crater far more frequently than most other compiler contributors.
There was a problem hiding this comment.
Sounds find to me. cc @Mark-Simulacrum and @pietroalbini
There was a problem hiding this comment.
I'm fine with types having crater access.
aliemjay
reviewed
Mar 28, 2023
Co-authored-by: Ali MJ Al-Nasrawy <[email protected]>
rylev
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all our members are compiler-contributors, compiler or other similar team members.
In rust-lang/rust#109388 (comment) @aliemjay was unable to run perf.