Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding embedded-wg team definitions #650

Merged
merged 3 commits into from
Apr 5, 2022

Conversation

ryankurte
Copy link
Contributor

Adds the remainder of the embedded-wg teams based on membership here per rust-embedded/wg#442, towards moving team mailinglists over to central hosting.

cc. @pietroalbini

Copy link
Member

@pietroalbini pietroalbini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking long to review! Just a small change.

@adamgreig
Copy link
Member

Any chance we could get this merged, possibly without the new URL? We've had some changes to the teams since the PR, but it's probably easier to apply them on top of this rather than resolve a merge afterwards.

(or @ryankurte maybe you could update the PR with the changes? we need to remove thejpster from risc-v, add him to tools, and add YuhanLiin to msp430)

@adamgreig
Copy link
Member

Friendly ping for anyone to review these changes please?

@ryankurte, could you add @newAM to the cortex-m team in this PR, too?

@therealprof
Copy link
Contributor

@ryankurte Can you address the wrong and missing team members?

Copy link
Contributor

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pietroalbini Any chance to get this merged?

@pietroalbini pietroalbini requested review from pietroalbini and removed request for pietroalbini April 1, 2022 13:45
@pietroalbini pietroalbini dismissed their stale review April 1, 2022 13:45

not in core anymore

@therealprof
Copy link
Contributor

@rust-lang/core Any change to get this reviewed?

Copy link
Member

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for taking so long. There's kind of a lack of a clear policy on how we want to handle working groups going forward which led to my hesitation to review this particular change (sorry. I should have communicated more clearly). That being said, since this is simply an addition to an existing working group and doesn't fundamentally change the structure of the project, I think it's fine to merge.

@rylev rylev merged commit 0b1ec4e into rust-lang:master Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants