Skip to content

Enable rustbot in rustc_codegen_cranelift&rustc_codegen_gcc #1790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Urgau
Copy link
Member

@Urgau Urgau commented Apr 25, 2025

This is going to be useful for enabling [no-mentions] and [issue-links] in both repository.

Which we should anyway to before enabling them in rust-lang/rust as otherwise subtree sync risk being flagged with warnings.

cc @bjorn3 @GuillaumeGomez @antoyo

@Kobzol
Copy link
Contributor

Kobzol commented Apr 25, 2025

I think that adding triagebot.toml is the main thing, this just adds write access to the triagebot account, but that shouldn't be needed for these checks (it's a good idea regardless though, to track that we use rustbot there).

Copy link

Dry-run check results

[WARN  sync_team] sync-team is running in dry mode, no changes will be applied.
[INFO  sync_team] synchronizing github
[INFO  sync_team] 💻 Repo Diffs:
    📝 Editing repo 'rust-lang/rustc_codegen_cranelift':
      Permission Changes:
        Giving user 'rustbot' write permission
    📝 Editing repo 'rust-lang/rustc_codegen_gcc':
      Permission Changes:
        Giving user 'rustbot' write permission

Copy link
Contributor

@antoyo antoyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgross35
Copy link
Contributor

I think that adding triagebot.toml is the main thing, this just adds write access to the triagebot account, but that shouldn't be needed for these checks (it's a good idea regardless though, to track that we use rustbot there).

Write access meaning to post comments, or to write to the repo? I can't think of any time it does the latter.

@Kobzol
Copy link
Contributor

Kobzol commented Apr 27, 2025

I think that anyone can post comments, write access means merging PRs and pushing commits.

@Urgau
Copy link
Member Author

Urgau commented Apr 27, 2025

Doesn't it also allow editing comments, hiding comments, ...? Both are required for these two triagebot features.

@Kobzol
Copy link
Contributor

Kobzol commented Apr 27, 2025

Good point! I guess it could hide its own comments, but definitely couldn't edit PR descriptions without the write permission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants