-
Notifications
You must be signed in to change notification settings - Fork 300
Enable rustbot in rustc_codegen_cranelift
&rustc_codegen_gcc
#1790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
I think that adding triagebot.toml is the main thing, this just adds write access to the triagebot account, but that shouldn't be needed for these checks (it's a good idea regardless though, to track that we use rustbot there). |
Dry-run check results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Write access meaning to post comments, or to write to the repo? I can't think of any time it does the latter. |
I think that anyone can post comments, write access means merging PRs and pushing commits. |
Doesn't it also allow editing comments, hiding comments, ...? Both are required for these two triagebot features. |
Good point! I guess it could hide its own comments, but definitely couldn't edit PR descriptions without the write permission. |
This is going to be useful for enabling
[no-mentions]
and[issue-links]
in both repository.Which we should anyway to before enabling them in rust-lang/rust as otherwise subtree sync risk being flagged with warnings.
cc @bjorn3 @GuillaumeGomez @antoyo