Skip to content

Set more WG teams as marker team #1784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

apiraino
Copy link
Contributor

Follow up to #1763

With this patch I am moving some WG teams from working-group to marker-team. The reasoning is (as per this comment and this other comment on Zulip) that these are more "ping lists" rather than full-fledged teams.

Please review these changes for inaccuracies, I am building a picture of the Rust project structure as I go :-)

If these changes are conceptually correct, then I'll figure out something to fix the validation error.

Thanks!

cc: @davidtwco
r? @ehuss

@apiraino apiraino force-pushed the set-more-teams-as-marker-team branch 2 times, most recently from 2f2e0a9 to df8fc29 Compare April 23, 2025 14:43
@ehuss
Copy link
Contributor

ehuss commented Apr 23, 2025

I don't think I would agree these would be good to set as marker teams. These don't seem like they are just used for pinging. Many of these teams have leads, an identity, and structure, and also include various permissions. I would also not recommend modifying archived teams (there's not much of a point for that).

@apiraino
Copy link
Contributor Author

apiraino commented Apr 23, 2025

I don't think I would agree these would be good to set as marker teams

All of them? Then I don't have clear the line that qualifies a team to be marker (as discussed on Zulip). You mean to just drop this patch or there's something to salvage? The WG-prio team has never been a team so at least that one should be ok :-)

@ehuss
Copy link
Contributor

ehuss commented Apr 25, 2025

I think for now my guidance would be: If the only purpose is to support @rustbot ping foo, then that would make sense to use a marker team. From what I can tell, all of these seem to be something more than that.

@apiraino apiraino closed this Apr 28, 2025
@apiraino apiraino force-pushed the set-more-teams-as-marker-team branch from df8fc29 to 56f8260 Compare April 28, 2025 10:10
@apiraino apiraino deleted the set-more-teams-as-marker-team branch April 28, 2025 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants