Switch cargo from bors to merge-queue #1590
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
ehuss
reviewed
Oct 23, 2024
|
|
||
| [access.teams] | ||
| cargo = "write" | ||
|
|
||
| [[branch-protections]] | ||
| pattern = "master" | ||
| ci-checks = ["conclusion"] |
There was a problem hiding this comment.
ci-checks will be needed on the rust-1.* branch protection, too. We use those for beta backports.
There was a problem hiding this comment.
Or...hm.. Merge queues don't support * patterns. That's...unfortunate.
I suppose we can merge without using queues, since we almost never have more than one PR targeting a branch at once. We can assume the PR is up-to-date. Perhaps we could expose the "Require branches to be up to date before merging" setting for the beta branches?
There was a problem hiding this comment.
If it's needed only for cargo (and rust-lang/rust), I would just configure it manually. TIL about the * limitation, that's annoying.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accompanying PR: rust-lang/cargo#14718