Skip to content

Retire wg-grammar #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Retire wg-grammar #1381

merged 1 commit into from
Apr 8, 2024

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Mar 16, 2024

wg-grammar has not met in several years, so I think it is time to go ahead and retire it. I don't foresee it starting up again. Also, I'm presuming that the spec team will be picking up this work in some form.

cc @rust-lang/wg-grammar
cc @rust-lang/spec

Copy link
Member

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r? @eddyb

@@ -0,0 +1,6 @@
org = "rust-lang"
name = "gll"
description = " GLL parsing framework."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we put something on the README and/or description explaining any detail about why this is archived? In other organizations I'm a part of, we make a habit of putting a prominent message in the README explaining where those looking at the repo should direct their attention.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! I posted rust-lang/gll#145 and rust-lang/wg-grammar#70. However, I'm not sure how active @eddyb is to be able to see this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, I'm not sure how active @eddyb is to be able to see this.

My notifications are a disaster because I didn't get myself out of @rust-lang/compiler the moment I stopped being able to pay attention to them, so while I keep every GitHub email for posterity, I have no easy way to be notified when people want me to look at anything under rust-lang/.
You pretty much have to DM me on Zulip or Discord for the time being, sorry!
(I've been trying to fix it but life keeps handing me lemons - also, theoretically the @eddyb on GitHub may have been enough to bypass that but maybe I need to do more email automation because I don't remember the GH mobile app catching it, and it's also terrible in other ways)


Also, IMO gll does not belong in rust-lang/, it's a toy parsing library developed originally under the @LykenSol org and it got moved because wg-grammar wanted some level of "vendoring". Completely unnecessary and it would be best to move it back if that's an option. (see also rust-lang/gll#145 (comment))

@Kobzol
Copy link
Contributor

Kobzol commented Apr 5, 2024

The wg-grammar repo now has the deprecation notice (rust-lang/wg-grammar#70). eddyb has asked for gll to be moved back under his org, so I suggest to remove gll from team, so that it can be moved out without sync-team recreating it.

@eddyb
Copy link
Member

eddyb commented Apr 5, 2024

Oops, raced a bit with @Kobzol's comment, I left mine further above as a review comment (#1381 (comment)), leaving this note here so it doesn't get missed (tho it mostly just adds more context, the conclusion is the same).

@ehuss
Copy link
Contributor Author

ehuss commented Apr 5, 2024

Sure! I have removed gll, and I think it should be safe to transfer it.

@Kobzol
Copy link
Contributor

Kobzol commented Apr 5, 2024

Ah, I didn't realize that gll wasn't even tracked before this PR. Yeah, so in that case we can transfer it independently of this PR.

@Kobzol Kobzol requested a review from rylev April 5, 2024 14:58
@rylev rylev merged commit d67f2e3 into rust-lang:master Apr 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants