Add launching-pad team. #1206
Add launching-pad team. #1206
Conversation
|
Opening as a draft because this will break the website until rust-lang/www.rust-lang.org#1914 is merged and deployed. In the future, I would like to make it so that subteam-of will be required, but we aren't quite there yet. One wrinkle is keeping track of the top-level teams in a way that makes sense. If they are subteams of the leadership-council, that will likely also cause problems for the website (and I'm not sure what else). |
| if !matches!(team.kind(), TeamKind::Team) && parent.subteam_of().is_some() { | ||
| bail!( | ||
| "{} `{}` can't be a subteam of a subteam (`{}`)", | ||
| team.kind(), | ||
| team.name(), | ||
| parent.name(), | ||
| ); | ||
| } | ||
|
|
There was a problem hiding this comment.
Sorry, I didn't get notified by the ping, maybe because this PR is marked as a draft? I saw this PR just now since I'm subscribed to this repo.
There was a problem hiding this comment.
I kept this check because it's not clear where to place WGs and PGs that are children of subteams on the website. Today, WGs and PGs are placed at the bottom of the page in distinct sections. It doesn't feel right to place WGs/PGs that aren't actually direct children of the team whose page we are looking at at the same level as other WGs/PGs especially since the user wouldn't necessarily be able to draw a connection between a given group and the respective parent team.
There was a problem hiding this comment.
For example:
Team A
+-- Team A-A
| +-- Working Group A-A-A
+-- Team A-B
The webpage of team A would look like:
Team A
--- Subteams
Team A-A
Team A-B
--- WGs
Working Group A-A-A
--- PGs
Now it's unclear if WG A-A-A is a direct child of A, A-A or A-B (without looking at their names of course which might not reflect the hierarchy).
There was a problem hiding this comment.
Note that for subsubteams (and sub^N-teams, N>2), I've made the website semi-preserve the hierarchy by walking the team structure in pre-order. The situation is slightly better since they're contained in the same section on the page.
|
@ehuss with rust-lang/www.rust-lang.org#1914 merged, is this ready for review? |
|
Review is fine, but it cannot be merged as the deploy is currently not working, see: https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/www.2Erust-lang.2Eorg.20deploy.20is.20failing/near/412879305 |
|
Now that the website has been deployed, this should be ready. |
This adds the launching-pad team, and connects all of its subteams into it. This should help with tracking the team membership and their status and connections.
cc @jonathanpallant