Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo-bisect-rustc repository under automation #1169

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

Kobzol
Copy link
Contributor

@Kobzol Kobzol commented Jan 6, 2024

Repo: https://github.com/rust-lang/cargo-bisect-rustc

Configuration extracted from GitHub:

org = "rust-lang"
name = "cargo-bisect-rustc"
description = "Bisects rustc, either nightlies or CI artifacts"
bots = []

[access.teams]
security = "pull"
compiler = "write"

[access.individuals]
ehuss = "write"
Aaron1011 = "write"
oli-obk = "write"
rust-lang-owner = "admin"
compiler-errors = "write"
badboy = "admin"
wesleywiser = "write"
eddyb = "write"
pietroalbini = "admin"
estebank = "write"
michaelwoerister = "write"
matthewjasper = "write"
spastorino = "admin"
chrissimpkins = "write"
Mark-Simulacrum = "admin"
pnkfelix = "write"
nagisa = "write"
lcnr = "write"
rylev = "admin"
jackh726 = "write"
jdno = "admin"
petrochenkov = "write"
cjgillot = "write"
davidtwco = "write"

@ehuss
Copy link
Contributor

ehuss commented Jan 6, 2024

I would like to keep write permissions here. I think in the short-term, can you add me under access.individuals?
Long term I don't know if it makes sense to create a dedicated sub-team. It doesn't matter for me since I am part of other teams, so for now it probably isn't worth it.

Also, I think it would be good to add a branch protection with the new required-approvals = 0 so that I can merge my own PRs. I generally prefer for repos to have some kind of branch protection, even if it is a weak one.

@Kobzol Kobzol force-pushed the repo-cargo-bisect-rustc branch from 4c37a20 to 8df6fc5 Compare January 6, 2024 20:58
@Kobzol
Copy link
Contributor Author

Kobzol commented Jan 6, 2024

Ah, I thought that you're in the compiler team, my bad. Changed.

Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

It looks like this also removes access for @chrissimpkins, @rylev, and @spastorino. I assume rylev's access was from being on core. I haven't seen the other two making changes for a few years.

@Kobzol Kobzol force-pushed the repo-cargo-bisect-rustc branch from 8df6fc5 to c2467a1 Compare January 7, 2024 07:55
@rylev rylev merged commit fd44dde into rust-lang:master Jan 8, 2024
1 check passed
@Kobzol Kobzol deleted the repo-cargo-bisect-rustc branch January 9, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants