This repository was archived by the owner on Mar 31, 2025. It is now read-only.
CI: add dry run job #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoieni
force-pushed
the
sync-team-dry-run
branch
2 times, most recently
from
2ff54d2 to
4300c34
Compare
marcoieni
commented
Feb 4, 2025
marcoieni
force-pushed
the
sync-team-dry-run
branch
from
4300c34 to
93dd846
Compare
marcoieni
commented
Feb 4, 2025
Kobzol
reviewed
Feb 5, 2025
|
(I don't have permissions here, so you'll need to ask Mark or someone else to do a review). |
jdno
suggested changes
Feb 12, 2025
There was a problem hiding this comment.
I've commented on a few things I've noted. We should definitely fix the environment variable names, the other comments are mostly suggestions. I'm not super familiar with the codebase of sync-team and others can probably give better feedback on the implementation, but it looks reasonable. 👍
marcoieni
force-pushed
the
sync-team-dry-run
branch
from
93dd846 to
7758a61
Compare
jdno
approved these changes
Feb 14, 2025
Closed
|
The logs after we merged this look identical to the previous run 👍 |
|
🎉 🎉 🎉 Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.