Support ARM crypto extension on A32/T32 #929
Conversation
|
r? @Amanieu (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -40,6 +54,7 @@ use stdarch_test::assert_instr; | |||
| /// AES single round encryption. | |||
| #[inline] | |||
| #[target_feature(enable = "crypto")] | |||
| #[cfg_attr(target_arch = "arm", target_feature(enable = "v8"))] | |||
There was a problem hiding this comment.
Is the v8 feature actually required here? Does it work without this feature?
There was a problem hiding this comment.
Is the
v8feature actually required here? Does it work without this feature?
Yes, v8 feature is required since this is ARMv8 feature. If this is v7 or nothing, this causes LLVM ERROR: Cannot select: intrinsic %llvm.arm.neon.aese .
|
Per #1003, it looks like this PR potentially broke the crypto extension on |
|
It doesn't seem like there's any problem at all with using them: https://rust.godbolt.org/z/r4Yhdn Maybe it's just a rustdoc bug? |
|
Huh wow, strange! |
|
Seems plausible. I guess #1003 can be closed as a dup then? |
ARM Crypto Extensions supports on aarch32 too. So we should allow this intrinsics on arm.